getsentry / getsentry/sentry-java

Ok Http Retry Tracking using the EventListner API?

Aberta
#4,161 2 comentários 0 reações 0 responsáveis Ver no GitHub
Android Improvement Spans
Linguagem predominante
Kotlin
Estrelas
1.4k
Forks
478
Merge médio
2d 22h
PRs com merge (30d)
69

Descrição

### Description

Hello Team, I have a question about how we are tracking the network metrics using the OkHttp EventListenerAPI here - https://github.com/getsentry/sentry-java/blob/main/sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpEventListener.kt

From my understanding, with the current implementation, if a request is retried, the event listener only captures metrics for the latest attempt and does not track metrics for each retry separately. So, if there are three requests (one original and two retries), we only see metrics for the last one. I understand that some metrics, like CONNECT, SSL, and DNS, would only be recorded for the initial request since OkHttp reuses the connection. However, other metrics could still be relevant for retries.

Was there a specific reason for implementing it this way?

Looking forward to your insights!

Guia de contribuição

Abrir o guia de contribuição

Direção de pesquisa

Start with sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpEventListener.kt and the OkHttp EventListener API to understand how attempts are observed. The issue does not define a requested change or acceptance criteria; clarify whether retry attempts should be tracked separately and what completion means before implementation.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
kotlin
Domínio
observability
Tipo de issue
Funcionalidade
Dificuldade
5/5
Tempo estimado
Mais de uma semana
Status de atividade
Estagnada
Clareza
Precisa de esclarecimento
Facilidade para iniciantes
15/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.