Validate if mock_callable() target has left over references
- Ngôn ngữ chính
- Python
- Star
- 149
- Fork
- 62
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
mock_constructor has [validation logic](https://github.com/facebookincubator/TestSlide/blob/master/testslide/mock_constructor.py#L275-L295) to find out if the class being mocked has other references that are not from the module where it lives. This is important, as there's no guarantees it is gonna work otherwise.
mock_callable has the same potential problem when mocking functions at modules for example: if there are left over references such as `from module import func`, it will not work.
Let's add such validation to mock_callable so users don't shoot themselves in the foot.
This logic can be added [here](https://github.com/facebookincubator/TestSlide/blob/master/testslide/mock_callable.py#L488).
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.