Validate if mock_callable() target has left over references
未关闭
enhancement
help wanted
mock(_async)_callable
- 主要语言
- Python
- 星标
- 149
- 派生
- 62
- PR 合并指标
- 30 天内没有已合并 PR
描述
mock_constructor has [validation logic](https://github.com/facebookincubator/TestSlide/blob/master/testslide/mock_constructor.py#L275-L295) to find out if the class being mocked has other references that are not from the module where it lives. This is important, as there's no guarantees it is gonna work otherwise.
mock_callable has the same potential problem when mocking functions at modules for example: if there are left over references such as `from module import func`, it will not work.
Let's add such validation to mock_callable so users don't shoot themselves in the foot.
This logic can be added [here](https://github.com/facebookincubator/TestSlide/blob/master/testslide/mock_callable.py#L488).
贡献指南
评估
这个 Issue 还没有评估数据。