facebook / facebook/TestSlide

Validate if mock_callable() target has left over references

Offen
#58 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
enhancement help wanted mock(_async)_callable
Vorherrschende Sprache
Python
Sterne
149
Forks
62
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

mock_constructor has [validation logic](https://github.com/facebookincubator/TestSlide/blob/master/testslide/mock_constructor.py#L275-L295) to find out if the class being mocked has other references that are not from the module where it lives. This is important, as there's no guarantees it is gonna work otherwise.

mock_callable has the same potential problem when mocking functions at modules for example: if there are left over references such as `from module import func`, it will not work.

Let's add such validation to mock_callable so users don't shoot themselves in the foot.

This logic can be added [here](https://github.com/facebookincubator/TestSlide/blob/master/testslide/mock_callable.py#L488).

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.