codingjoe / codingjoe/threadmill
Uncovered pre-existing branches in the Redis backend
- 主要言語
- Python
- スター
- 12
- フォーク
- 1
- 平均マージ
- 1日 1時間
- マージ済み PR(30日)
- 10
説明
Found by `testJoe` while adding coverage for the fair multi-queue rotation (`codingjoe-fair-multi-queue-scheduling`), and confirmed pre-existing (untouched by that diff):
`defer: pre-existing uncovered lines threadmill/backends/redis.py L147-148, L445, L494-495. Unrelated to this diff. [threadmill/backends/redis.py]`
The four lines are:
- `L147-148` — the `ValueError` raised when `REDIS_URL` is missing from the backend params.
- `L445` — `raise TaskResultDoesNotExist(...)` in `get_result()`.
- `L494-495` — the `except ValueError: continue` that drops malformed pub/sub payloads in `worker_telemetry()`.
None are reachable from the current test suite, so `uv run pytest` reports them as missing. Add direct tests (a backend without `REDIS_URL`, an unknown result id, a malformed telemetry message) or delete the branches that no caller can reach.
コントリビューションガイド
調査の方向性
Start in threadmill/backends/redis.py at lines 147-148, 445, and 494-495, then inspect the existing Redis backend tests. Run `uv run pytest` to confirm the uncovered branches, and add direct coverage for missing REDIS_URL, an unknown result id, and malformed telemetry; done means the tests pass without those lines remaining uncovered.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- python, redis
- 領域
- backend, databases, testing
- issue の種類
- リファクタリング
- 難易度
- 2/5
- 見積もり時間
- 半日
- 活発さ
- 活発
- 明瞭さ
- 明確に書かれている
- 初心者へのやさしさ
- 84/100