codingjoe / codingjoe/threadmill
Uncovered pre-existing branches in the Redis backend
- 主要语言
- Python
- 星标
- 12
- 派生
- 1
- 平均合并
- 1 天 1 小时
- 30 天内合并 PR
- 10
描述
Found by `testJoe` while adding coverage for the fair multi-queue rotation (`codingjoe-fair-multi-queue-scheduling`), and confirmed pre-existing (untouched by that diff):
`defer: pre-existing uncovered lines threadmill/backends/redis.py L147-148, L445, L494-495. Unrelated to this diff. [threadmill/backends/redis.py]`
The four lines are:
- `L147-148` — the `ValueError` raised when `REDIS_URL` is missing from the backend params.
- `L445` — `raise TaskResultDoesNotExist(...)` in `get_result()`.
- `L494-495` — the `except ValueError: continue` that drops malformed pub/sub payloads in `worker_telemetry()`.
None are reachable from the current test suite, so `uv run pytest` reports them as missing. Add direct tests (a backend without `REDIS_URL`, an unknown result id, a malformed telemetry message) or delete the branches that no caller can reach.
贡献指南
调研方向
Start in threadmill/backends/redis.py at lines 147-148, 445, and 494-495, then inspect the existing Redis backend tests. Run `uv run pytest` to confirm the uncovered branches, and add direct coverage for missing REDIS_URL, an unknown result id, and malformed telemetry; done means the tests pass without those lines remaining uncovered.
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python, redis
- 领域
- backend, databases, testing
- Issue 类型
- 重构
- 难度
- 2/5
- 预计耗时
- 半天
- 活跃度
- 活跃
- 描述清晰度
- 描述清楚
- 新手友好度
- 84/100