codingjoe / codingjoe/threadmill
Uncovered pre-existing branches in the Redis backend
- Langage dominant
- Python
- Étoiles
- 12
- Forks
- 1
- Merge moyen
- 1 j 1 h
- PR mergées (30 j)
- 10
Description
Found by `testJoe` while adding coverage for the fair multi-queue rotation (`codingjoe-fair-multi-queue-scheduling`), and confirmed pre-existing (untouched by that diff):
`defer: pre-existing uncovered lines threadmill/backends/redis.py L147-148, L445, L494-495. Unrelated to this diff. [threadmill/backends/redis.py]`
The four lines are:
- `L147-148` — the `ValueError` raised when `REDIS_URL` is missing from the backend params.
- `L445` — `raise TaskResultDoesNotExist(...)` in `get_result()`.
- `L494-495` — the `except ValueError: continue` that drops malformed pub/sub payloads in `worker_telemetry()`.
None are reachable from the current test suite, so `uv run pytest` reports them as missing. Add direct tests (a backend without `REDIS_URL`, an unknown result id, a malformed telemetry message) or delete the branches that no caller can reach.
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Start in threadmill/backends/redis.py at lines 147-148, 445, and 494-495, then inspect the existing Redis backend tests. Run `uv run pytest` to confirm the uncovered branches, and add direct coverage for missing REDIS_URL, an unknown result id, and malformed telemetry; done means the tests pass without those lines remaining uncovered.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- python, redis
- Domaine
- backend, databases, testing
- Type d'issue
- Refactorisation
- Difficulté
- 2/5
- Temps estimé
- Une demi-journée
- Activité
- Active
- Clarté
- Clairement spécifiée
- Accessibilité débutants
- 84/100