coder / coder/envbuilder

Feat: add option to skip owner transfer of home-dir

オープン
#461 コメント 0 件 リアクション 1 件 担当者 0 名 GitHub で見る
主要言語
Go
スター
300
フォーク
64
平均マージ
20分
マージ済み PR(30日)
1

説明

Hey!
We see that some of our workspaces with large home-dirs uses quite a bit of time on the owner-transfer-step:

```log
#3: 🔄 Updating ownership of /home/coder...
#3: 🏡 Updated ownership of /home/coder! [2m1.175064722s]
```

This might be a somewhat extreme case, where the home-dir has a couple of `pipx`-installs, and `pyenv`-venvs. Where the home-dir has been prebuild, and comes with the image.
In our case this is already owned by the `coder`-user, and the ownership does not seem to be shifted to `root` on envbuild, so in this case, the ownership-transfer seems to be redundant.

So tested with removing the ownership-transfer (https://github.com/coder/envbuilder/blob/7eabaa4d876c3ce54f7271b6e68fea37b6719c66/envbuilder.go#L829-L842), and could not see any issues with ownership in our case. So if envbuilder had an option to disable that, that would be great

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。