Feat: add option to skip owner transfer of home-dir
- 主要语言
- Go
- 星标
- 300
- 派生
- 64
- 平均合并
- 20 分钟
- 30 天内合并 PR
- 1
描述
Hey!
We see that some of our workspaces with large home-dirs uses quite a bit of time on the owner-transfer-step:
```log
#3: 🔄 Updating ownership of /home/coder...
#3: 🏡 Updated ownership of /home/coder! [2m1.175064722s]
```
This might be a somewhat extreme case, where the home-dir has a couple of `pipx`-installs, and `pyenv`-venvs. Where the home-dir has been prebuild, and comes with the image.
In our case this is already owned by the `coder`-user, and the ownership does not seem to be shifted to `root` on envbuild, so in this case, the ownership-transfer seems to be redundant.
So tested with removing the ownership-transfer (https://github.com/coder/envbuilder/blob/7eabaa4d876c3ce54f7271b6e68fea37b6719c66/envbuilder.go#L829-L842), and could not see any issues with ownership in our case. So if envbuilder had an option to disable that, that would be great
贡献指南
这个仓库没有索引到贡献指南
调研方向
首先阅读 envbuilder.go 中大约第 829-842 行的内容,那里会转移 /home/coder 的所有权。跟踪现有选项的定义方式以及它们如何传递给这一步,然后添加一个跳过转移的选项,同时保留当前的默认行为。当该选项可用,并且启用该选项时省略所有权转移步骤,即表示完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- go
- 领域
- devops
- Issue 类型
- 功能
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 52/100