code-corps / code-corps/code-corps-ember

Discussion: Add ability to approve any unapproved project in admin UI

Đang mở
#1,581 1 bình luận 0 reaction 0 người được giao Xem trên GitHub
Ngôn ngữ chính
JavaScript
Star
120
Fork
75
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

# Problem

At the moment, only projects with `approved: false, approvalRequested: true` can be approved, which, in a non-direct way, supports the API requiring the presence of long description for approved projects

- an org owner can create a project without long description
- an admin cannot approve such a project through the UI
- if an admin tries to approve such a project through the API directly, they will get a validation error
- an org owner can request approval once they provide a long description
- an admin can approve such a project both through the UI and the API directly

Really, in the background, this only affects the admins and no one else, so I'm not sure it's worth our time to change anything at the moment, but what we could do, is support approving a project as long as they have a `longDescritption`, without necessarily being in `approvalRequested` status

It would take 30 minutes to do, but i'm not sure it's wise or useful, simply because there may be a scenario where an owner might provide an incomplete long description, but not be ready for approval yet.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.