code-corps / code-corps/code-corps-ember

Discussion: Add ability to approve any unapproved project in admin UI

オープン
#1,581 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
JavaScript
スター
120
フォーク
75
PR マージ指標
30日以内にマージされた PR はありません

説明

# Problem

At the moment, only projects with `approved: false, approvalRequested: true` can be approved, which, in a non-direct way, supports the API requiring the presence of long description for approved projects

- an org owner can create a project without long description
- an admin cannot approve such a project through the UI
- if an admin tries to approve such a project through the API directly, they will get a validation error
- an org owner can request approval once they provide a long description
- an admin can approve such a project both through the UI and the API directly

Really, in the background, this only affects the admins and no one else, so I'm not sure it's worth our time to change anything at the moment, but what we could do, is support approving a project as long as they have a `longDescritption`, without necessarily being in `approvalRequested` status

It would take 30 minutes to do, but i'm not sure it's wise or useful, simply because there may be a scenario where an owner might provide an incomplete long description, but not be ready for approval yet.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。