code-corps / code-corps/code-corps-ember

Discussion: Add ability to approve any unapproved project in admin UI

未关闭
#1,581 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
120
派生
75
PR 合并指标
30 天内没有已合并 PR

描述

# Problem

At the moment, only projects with `approved: false, approvalRequested: true` can be approved, which, in a non-direct way, supports the API requiring the presence of long description for approved projects

- an org owner can create a project without long description
- an admin cannot approve such a project through the UI
- if an admin tries to approve such a project through the API directly, they will get a validation error
- an org owner can request approval once they provide a long description
- an admin can approve such a project both through the UI and the API directly

Really, in the background, this only affects the admins and no one else, so I'm not sure it's worth our time to change anything at the moment, but what we could do, is support approving a project as long as they have a `longDescritption`, without necessarily being in `approvalRequested` status

It would take 30 minutes to do, but i'm not sure it's wise or useful, simply because there may be a scenario where an owner might provide an incomplete long description, but not be ready for approval yet.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。