code-corps / code-corps/code-corps-ember

Deprecation: Native dom helpers should not be used as globals in tests anymore

Đang mở
#1,207 2 bình luận 0 reaction 0 người được giao Xem trên GitHub
Skill: ember-cli-page-object Skill: Ember.js Skill: JavaScript
Ngôn ngữ chính
JavaScript
Star
120
Fork
75
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

# Problem

Using native dom helpers as globals is now deprecated in our tests. Instead, we should add a new dependency to our app and import these helpers from it in any tests that need it.

We are leaning away from these anyway, due to relying on ember-cli-page-object, but there are still a couple of places where we do use them.

## Subtasks
- [ ] Install depdencency https://github.com/cibernox/ember-native-dom-helpers
- [ ] Search through our tests for usage of the `find`, `click`, `fillIn`, `visit` and other global functions in this group. Careful not to mistake them for the identically named functions provided by `ember-cli-page-object`. The culprits we need to fixed are likely used as globals, in tests, directly.
- [ ] In any module that uses them, import them using `import { visit, click, find, fillIn } from 'ember-native-dom-helpers';`

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.