code-corps / code-corps/code-corps-ember

Deprecation: Native dom helpers should not be used as globals in tests anymore

未关闭
#1,207 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Skill: ember-cli-page-object Skill: Ember.js Skill: JavaScript
主要语言
JavaScript
星标
120
派生
75
PR 合并指标
30 天内没有已合并 PR

描述

# Problem

Using native dom helpers as globals is now deprecated in our tests. Instead, we should add a new dependency to our app and import these helpers from it in any tests that need it.

We are leaning away from these anyway, due to relying on ember-cli-page-object, but there are still a couple of places where we do use them.

## Subtasks
- [ ] Install depdencency https://github.com/cibernox/ember-native-dom-helpers
- [ ] Search through our tests for usage of the `find`, `click`, `fillIn`, `visit` and other global functions in this group. Careful not to mistake them for the identically named functions provided by `ember-cli-page-object`. The culprits we need to fixed are likely used as globals, in tests, directly.
- [ ] In any module that uses them, import them using `import { visit, click, find, fillIn } from 'ember-native-dom-helpers';`

贡献指南

打开贡献指南

调研方向

首先检查测试文件和包配置,然后在测试中搜索全局的 find、click、fillIn、visit 及相关 helper。区分原生 DOM helper 与同名的 ember-cli-page-object 函数,添加 ember-native-dom-helpers 依赖,并在每个受影响的模块中导入原生 helper。当不再有任何原生 helper 的使用依赖 globals 时,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
frontend, testing-qa
Issue 类型
重构
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
38/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。