code-corps / code-corps/code-corps-ember

Deprecation: Native dom helpers should not be used as globals in tests anymore

未關閉
#1,207 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
Skill: ember-cli-page-object Skill: Ember.js Skill: JavaScript
主要語言
JavaScript
星號
120
分支
75
PR 合併指標
30 天內沒有已合併 PR

描述

# Problem

Using native dom helpers as globals is now deprecated in our tests. Instead, we should add a new dependency to our app and import these helpers from it in any tests that need it.

We are leaning away from these anyway, due to relying on ember-cli-page-object, but there are still a couple of places where we do use them.

## Subtasks
- [ ] Install depdencency https://github.com/cibernox/ember-native-dom-helpers
- [ ] Search through our tests for usage of the `find`, `click`, `fillIn`, `visit` and other global functions in this group. Careful not to mistake them for the identically named functions provided by `ember-cli-page-object`. The culprits we need to fixed are likely used as globals, in tests, directly.
- [ ] In any module that uses them, import them using `import { visit, click, find, fillIn } from 'ember-native-dom-helpers';`

貢獻指南

開啟貢獻指南

研究方向

先檢視測試檔案與套件設定,接著在測試中搜尋全域的 find、click、fillIn、visit 及相關 helper。區分原生 DOM helper 與同名的 ember-cli-page-object 函式,加入 ember-native-dom-helpers 相依套件,並在每個受影響的模組中匯入原生 helper。當不再有任何原生 helper 的使用依賴 globals 時,即表示完成。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
javascript
領域
frontend, testing-qa
Issue 類型
重構
難度
3/5
預估耗時
1-2 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
38/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。