code-corps / code-corps/code-corps-ember
Only task authors as well as project contributors or higher can edit task skills.
- Ngôn ngữ chính
- JavaScript
- Star
- 120
- Fork
- 75
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
# Problem
Right now on project/tasks/task.hbs, the UI to remove and add task skills is accessible by anyone.
We should change this so that only users who are able to edit tasks can interact with this part of the UI.
## Subtasks
- [ ] Wrap the `skill-button` collection as well as the `skill-typeahead` UI with an `{{#if (can 'edit task' task)}}` block
- [ ] Put a `{{related-skills}} component into the `else` part of the block.
- [ ] Fix any broken tests
- [ ] Add an acceptance test to `acceptance/task-editing-test.js` along the lines of "skills cannot be assigned to/from a task if user is not able to".
- [ ] Possibly: Add properties to `tests/pages/project/tasks/task.js` to support the above acceptance test. Something like `rendersTaskSkillsList`, `rendersRelatedSkills`, `rendersSkillsTypeahead`, etc.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.