code-corps / code-corps/code-corps-ember

Only task authors as well as project contributors or higher can edit task skills.

Abierto
#1,043 4 comentarios 0 reacciones 0 asignados Ver en GitHub
blocked Difficulty: Easy needs clarification needs design
Lenguaje dominante
JavaScript
Estrellas
120
Forks
75
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

# Problem

Right now on project/tasks/task.hbs, the UI to remove and add task skills is accessible by anyone.

We should change this so that only users who are able to edit tasks can interact with this part of the UI.

## Subtasks

- [ ] Wrap the `skill-button` collection as well as the `skill-typeahead` UI with an `{{#if (can 'edit task' task)}}` block
- [ ] Put a `{{related-skills}} component into the `else` part of the block.
- [ ] Fix any broken tests
- [ ] Add an acceptance test to `acceptance/task-editing-test.js` along the lines of "skills cannot be assigned to/from a task if user is not able to".
- [ ] Possibly: Add properties to `tests/pages/project/tasks/task.js` to support the above acceptance test. Something like `rendersTaskSkillsList`, `rendersRelatedSkills`, `rendersSkillsTypeahead`, etc.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.