code-corps / code-corps/code-corps-ember

Only task authors as well as project contributors or higher can edit task skills.

未关闭
#1,043 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
blocked Difficulty: Easy needs clarification needs design
主要语言
JavaScript
星标
120
派生
75
PR 合并指标
30 天内没有已合并 PR

描述

# Problem

Right now on project/tasks/task.hbs, the UI to remove and add task skills is accessible by anyone.

We should change this so that only users who are able to edit tasks can interact with this part of the UI.

## Subtasks

- [ ] Wrap the `skill-button` collection as well as the `skill-typeahead` UI with an `{{#if (can 'edit task' task)}}` block
- [ ] Put a `{{related-skills}} component into the `else` part of the block.
- [ ] Fix any broken tests
- [ ] Add an acceptance test to `acceptance/task-editing-test.js` along the lines of "skills cannot be assigned to/from a task if user is not able to".
- [ ] Possibly: Add properties to `tests/pages/project/tasks/task.js` to support the above acceptance test. Something like `rendersTaskSkillsList`, `rendersRelatedSkills`, `rendersSkillsTypeahead`, etc.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。