code-corps / code-corps/code-corps-api

Clean up CodeCorps.Emails.Transmissions.Receipt

未關閉
#1,337 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
blocked needs clarification needs estimate
主要語言
Elixir
星號
234
分支
82
PR 合併指標
30 天內沒有已合併 PR

描述

# Problem

In #1332, and even before that, `CodeCorps.Emails.Transmissions.Receipt.build` is wrapped into a `with` statement with multiple points of failure.

The event handler code which sends this email also wrapps that call into multiple points of failure.

The border between these seems arbitrary and, more importantly, The behavior of the `Receipt` itself is inconsistent with all other emails.

We should move these points of failure into the event handler and keep the `Receipt` itself _infallible_.

Then, we should decide if the points of failure actually make sense or if it's too defensive. This is old code, so it's quite possible we made some mistakes there.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。