code-corps / code-corps/code-corps-api

Clean up CodeCorps.Emails.Transmissions.Receipt

未关闭
#1,337 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
blocked needs clarification needs estimate
主要语言
Elixir
星标
234
派生
82
PR 合并指标
30 天内没有已合并 PR

描述

# Problem

In #1332, and even before that, `CodeCorps.Emails.Transmissions.Receipt.build` is wrapped into a `with` statement with multiple points of failure.

The event handler code which sends this email also wrapps that call into multiple points of failure.

The border between these seems arbitrary and, more importantly, The behavior of the `Receipt` itself is inconsistent with all other emails.

We should move these points of failure into the event handler and keep the `Receipt` itself _infallible_.

Then, we should decide if the points of failure actually make sense or if it's too defensive. This is old code, so it's quite possible we made some mistakes there.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。