code-corps / code-corps/code-corps-api

Clean up CodeCorps.Emails.Transmissions.Receipt

Ouverte
#1,337 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
blocked needs clarification needs estimate
Langage dominant
Elixir
Étoiles
234
Forks
82
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

# Problem

In #1332, and even before that, `CodeCorps.Emails.Transmissions.Receipt.build` is wrapped into a `with` statement with multiple points of failure.

The event handler code which sends this email also wrapps that call into multiple points of failure.

The border between these seems arbitrary and, more importantly, The behavior of the `Receipt` itself is inconsistent with all other emails.

We should move these points of failure into the event handler and keep the `Receipt` itself _infallible_.

Then, we should decide if the points of failure actually make sense or if it's too defensive. This is old code, so it's quite possible we made some mistakes there.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.