code-corps / code-corps/code-corps-api

Clean up CodeCorps.Emails.Transmissions.Receipt

Aperta
#1,337 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
blocked needs clarification needs estimate
Lingua principale
Elixir
Stelle
234
Fork
82
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

# Problem

In #1332, and even before that, `CodeCorps.Emails.Transmissions.Receipt.build` is wrapped into a `with` statement with multiple points of failure.

The event handler code which sends this email also wrapps that call into multiple points of failure.

The border between these seems arbitrary and, more importantly, The behavior of the `Receipt` itself is inconsistent with all other emails.

We should move these points of failure into the event handler and keep the `Receipt` itself _infallible_.

Then, we should decide if the points of failure actually make sense or if it's too defensive. This is old code, so it's quite possible we made some mistakes there.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.