cloudinary / cloudinary/cloudinary_java

Replace Map usage with OOP design classes

未關閉
#86 3 則留言 7 個 reaction 已指派 1 人 已被 @aleksandar-cloudinary 認領 在 GitHub 檢視
enhancement
主要語言
Java
星號
175
分支
113
PR 合併指標
30 天內沒有已合併 PR

描述

I am currently testing your service and evaluating to be your customer. But i am dissapointedd from the _Java integration_ you provide.

Everywhere you pass generic `Map` instances holding `String` key value pairs for configuration, upload options / results. That is not suitable for an object oriented programming language, and looks like 15 years ago programming style (including underscores).

Also enumeration classes could be used for fixed parameters like transformations and meaningfull exceptions shall be thrown. To detect a **_resource not found_** exception one must check the generic message like `if (e.getMessage().contains("Resource not found"))`.

That key-value and error message approach is very error prone and really not developer friendly.

**Example:**

String publicId = (String) uploadResult.get("public_id");

**Could be:**

String publicId = uploadResult.getPublicId();

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。