cloudinary / cloudinary/cloudinary_java

Replace Map usage with OOP design classes

Aperta
#86 3 commenti 7 reazioni 1 assegnatario Rivendicata da @aleksandar-cloudinary Vedi su GitHub
enhancement
Lingua principale
Java
Stelle
175
Fork
113
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I am currently testing your service and evaluating to be your customer. But i am dissapointedd from the _Java integration_ you provide.

Everywhere you pass generic `Map` instances holding `String` key value pairs for configuration, upload options / results. That is not suitable for an object oriented programming language, and looks like 15 years ago programming style (including underscores).

Also enumeration classes could be used for fixed parameters like transformations and meaningfull exceptions shall be thrown. To detect a **_resource not found_** exception one must check the generic message like `if (e.getMessage().contains("Resource not found"))`.

That key-value and error message approach is very error prone and really not developer friendly.

**Example:**

String publicId = (String) uploadResult.get("public_id");

**Could be:**

String publicId = uploadResult.getPublicId();

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.