cloudinary / cloudinary/cloudinary_java

Replace Map usage with OOP design classes

Offen
#86 3 Kommentare 7 Reaktionen 1 zugewiesene Person Beansprucht von @aleksandar-cloudinary Auf GitHub ansehen
enhancement
Vorherrschende Sprache
Java
Sterne
175
Forks
113
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

I am currently testing your service and evaluating to be your customer. But i am dissapointedd from the _Java integration_ you provide.

Everywhere you pass generic `Map` instances holding `String` key value pairs for configuration, upload options / results. That is not suitable for an object oriented programming language, and looks like 15 years ago programming style (including underscores).

Also enumeration classes could be used for fixed parameters like transformations and meaningfull exceptions shall be thrown. To detect a **_resource not found_** exception one must check the generic message like `if (e.getMessage().contains("Resource not found"))`.

That key-value and error message approach is very error prone and really not developer friendly.

**Example:**

String publicId = (String) uploadResult.get("public_id");

**Could be:**

String publicId = uploadResult.getPublicId();

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.