cloudinary / cloudinary/cloudinary_java

Replace Map usage with OOP design classes

Open
#86 3 comments 7 reactions 1 assignee Claimed by @aleksandar-cloudinary View on GitHub
enhancement
Dominant language
Java
Stars
175
Forks
113
PR merge metrics
No merged PRs in 30d

Description

I am currently testing your service and evaluating to be your customer. But i am dissapointedd from the _Java integration_ you provide.

Everywhere you pass generic `Map` instances holding `String` key value pairs for configuration, upload options / results. That is not suitable for an object oriented programming language, and looks like 15 years ago programming style (including underscores).

Also enumeration classes could be used for fixed parameters like transformations and meaningfull exceptions shall be thrown. To detect a **_resource not found_** exception one must check the generic message like `if (e.getMessage().contains("Resource not found"))`.

That key-value and error message approach is very error prone and really not developer friendly.

**Example:**

String publicId = (String) uploadResult.get("public_id");

**Could be:**

String publicId = uploadResult.getPublicId();

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.