callstack / callstack/react-theme-provider
Improve support for React v18
- 主要言語
- JavaScript
- スター
- 467
- フォーク
- 53
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
Hi! 👋
Firstly, thanks for your work on this project! 🙂
With React v18 children is expected to be explicitly typed
I've used [patch-package](https://github.com/ds300/patch-package) to patch `@callstack/react-theme-provider@3.0.8`
Here is the diff that solved my problem:
```diff
diff --git a/node_modules/@callstack/react-theme-provider/typings/index.d.ts b/node_modules/@callstack/react-theme-provider/typings/index.d.ts
index fd76d0e..df3cf54 100644
--- a/node_modules/@callstack/react-theme-provider/typings/index.d.ts
+++ b/node_modules/@callstack/react-theme-provider/typings/index.d.ts
@@ -8,7 +8,7 @@ type $Without = T extends any ? Pick = { [P in keyof T]?: $DeepPartial };
export type ThemingType = {
- ThemeProvider: React.ComponentType<{ theme?: Theme }>;
+ ThemeProvider: React.ComponentType<{ theme?: Theme; children: React.ReactNode }>;
withTheme: (
WrappedComponent: React.ComponentType & C
) => React.ComponentType<
```
コントリビューションガイド
評価
この issue はまだ評価されていません。