callstack / callstack/react-theme-provider

Improve support for React v18

Abierto
#144 3 comentarios 4 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
467
Forks
53
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Hi! 👋

Firstly, thanks for your work on this project! 🙂

With React v18 children is expected to be explicitly typed

I've used [patch-package](https://github.com/ds300/patch-package) to patch `@callstack/react-theme-provider@3.0.8`

Here is the diff that solved my problem:

```diff
diff --git a/node_modules/@callstack/react-theme-provider/typings/index.d.ts b/node_modules/@callstack/react-theme-provider/typings/index.d.ts
index fd76d0e..df3cf54 100644
--- a/node_modules/@callstack/react-theme-provider/typings/index.d.ts
+++ b/node_modules/@callstack/react-theme-provider/typings/index.d.ts
@@ -8,7 +8,7 @@ type $Without = T extends any ? Pick = { [P in keyof T]?: $DeepPartial };

export type ThemingType = {
- ThemeProvider: React.ComponentType<{ theme?: Theme }>;
+ ThemeProvider: React.ComponentType<{ theme?: Theme; children: React.ReactNode }>;
withTheme: (
WrappedComponent: React.ComponentType & C
) => React.ComponentType<
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.