callstack / callstack/react-theme-provider

Improve support for React v18

Aperta
#144 3 commenti 4 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
467
Fork
53
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Hi! 👋

Firstly, thanks for your work on this project! 🙂

With React v18 children is expected to be explicitly typed

I've used [patch-package](https://github.com/ds300/patch-package) to patch `@callstack/react-theme-provider@3.0.8`

Here is the diff that solved my problem:

```diff
diff --git a/node_modules/@callstack/react-theme-provider/typings/index.d.ts b/node_modules/@callstack/react-theme-provider/typings/index.d.ts
index fd76d0e..df3cf54 100644
--- a/node_modules/@callstack/react-theme-provider/typings/index.d.ts
+++ b/node_modules/@callstack/react-theme-provider/typings/index.d.ts
@@ -8,7 +8,7 @@ type $Without = T extends any ? Pick = { [P in keyof T]?: $DeepPartial };

export type ThemingType = {
- ThemeProvider: React.ComponentType<{ theme?: Theme }>;
+ ThemeProvider: React.ComponentType<{ theme?: Theme; children: React.ReactNode }>;
withTheme: (
WrappedComponent: React.ComponentType & C
) => React.ComponentType<
```

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.