callstack / callstack/react-native-paper

Replace status prop with checked in ToggleButton component

Ouverte
#4,866 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
feature request
Langage dominant
TypeScript
Étoiles
14.5k
Forks
2.2k
Merge moyen
5 j 23 h
PR mergées (30 j)
12

Description

**Is your feature request related to a problem? Please describe.**
The `ToggleButton` component currently uses a `status` prop with string values `checked` | `unchecked`. This adds unnecessary complexity for a binary state.

**Describe the solution you'd like**
Replace the `status` prop with a boolean `checked` prop.

Before:
```typescript
const ToggleButtonExample = () => {
const [status, setStatus] = React.useState('checked');

const onButtonToggle = () => {
setStatus(status === 'checked' ? 'unchecked' : 'checked');
};

return (

);
};
```

After:
```typescript
const ToggleButtonExample = () => {
const [isChecked, setIsChecked] = React.useState(true);

const onButtonToggle = () => {
setIsChecked(s => !s);
};

return (

);
};
```

**Additional context**
A boolean checked prop is simpler, clearer, and more consistent with common React patterns than using string values like 'checked' and 'unchecked'.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.