callstack / callstack/react-native-paper

Replace status prop with checked in ToggleButton component

Abierto
#4,866 0 comentarios 0 reacciones 0 asignados Ver en GitHub
feature request
Lenguaje dominante
TypeScript
Estrellas
14.5k
Forks
2.2k
Merge medio
5 d 23 h
PR fusionados (30 d)
12

Descripción

**Is your feature request related to a problem? Please describe.**
The `ToggleButton` component currently uses a `status` prop with string values `checked` | `unchecked`. This adds unnecessary complexity for a binary state.

**Describe the solution you'd like**
Replace the `status` prop with a boolean `checked` prop.

Before:
```typescript
const ToggleButtonExample = () => {
const [status, setStatus] = React.useState('checked');

const onButtonToggle = () => {
setStatus(status === 'checked' ? 'unchecked' : 'checked');
};

return (

);
};
```

After:
```typescript
const ToggleButtonExample = () => {
const [isChecked, setIsChecked] = React.useState(true);

const onButtonToggle = () => {
setIsChecked(s => !s);
};

return (

);
};
```

**Additional context**
A boolean checked prop is simpler, clearer, and more consistent with common React patterns than using string values like 'checked' and 'unchecked'.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.