callstack / callstack/react-native-paper
Replace status prop with checked in ToggleButton component
- Vorherrschende Sprache
- TypeScript
- Sterne
- 14.5k
- Forks
- 2.2k
- Ø Merge
- 5 T. 23 Std.
- Gemergte PRs (30 T.)
- 12
Beschreibung
**Is your feature request related to a problem? Please describe.**
The `ToggleButton` component currently uses a `status` prop with string values `checked` | `unchecked`. This adds unnecessary complexity for a binary state.
**Describe the solution you'd like**
Replace the `status` prop with a boolean `checked` prop.
Before:
```typescript
const ToggleButtonExample = () => {
const [status, setStatus] = React.useState('checked');
const onButtonToggle = () => {
setStatus(status === 'checked' ? 'unchecked' : 'checked');
};
return (
);
};
```
After:
```typescript
const ToggleButtonExample = () => {
const [isChecked, setIsChecked] = React.useState(true);
const onButtonToggle = () => {
setIsChecked(s => !s);
};
return (
);
};
```
**Additional context**
A boolean checked prop is simpler, clearer, and more consistent with common React patterns than using string values like 'checked' and 'unchecked'.
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.