Configurations like timeout, proxy, and ssl_verify should be parameterised
- Ngôn ngữ chính
- Python
- Star
- 459
- Fork
- 223
- Merge trung bình
- 8 giờ 57 phút
- Pull request đã merge (30 ngày)
- 13
Mô tả
Currently, in the Box SDK, configuring timeout, proxy, and SSL verify requires overriding the DefaultNetwork.request method.
class ProxyableBoxNetwork(DefaultNetwork):
def __init__(self, proxy_conf, verify, logger=None):
super(ProxyableBoxNetwork, self).__init__()
def request(self, method, url, access_token, **kwargs):
return super(ProxyableBoxNetwork, self).request(
method, url, access_token,
proxies=self._proxies,
verify=self._verify,
timeout=self._timeout,
**kwargs
)
Shouldn't these configurations be parameterised to allow straightforward setup without overriding?
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.