Configurations like timeout, proxy, and ssl_verify should be parameterised
- Lingua principale
- Python
- Stelle
- 459
- Fork
- 223
- Merge medio
- 8h 57m
- PR unite (30g)
- 13
Descrizione
Currently, in the Box SDK, configuring timeout, proxy, and SSL verify requires overriding the DefaultNetwork.request method.
class ProxyableBoxNetwork(DefaultNetwork):
def __init__(self, proxy_conf, verify, logger=None):
super(ProxyableBoxNetwork, self).__init__()
def request(self, method, url, access_token, **kwargs):
return super(ProxyableBoxNetwork, self).request(
method, url, access_token,
proxies=self._proxies,
verify=self._verify,
timeout=self._timeout,
**kwargs
)
Shouldn't these configurations be parameterised to allow straightforward setup without overriding?
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.