Configurations like timeout, proxy, and ssl_verify should be parameterised
- 主要语言
- Python
- 星标
- 459
- 派生
- 223
- 平均合并
- 8 小时 57 分钟
- 30 天内合并 PR
- 13
描述
Currently, in the Box SDK, configuring timeout, proxy, and SSL verify requires overriding the DefaultNetwork.request method.
class ProxyableBoxNetwork(DefaultNetwork):
def __init__(self, proxy_conf, verify, logger=None):
super(ProxyableBoxNetwork, self).__init__()
def request(self, method, url, access_token, **kwargs):
return super(ProxyableBoxNetwork, self).request(
method, url, access_token,
proxies=self._proxies,
verify=self._verify,
timeout=self._timeout,
**kwargs
)
Shouldn't these configurations be parameterised to allow straightforward setup without overriding?
贡献指南
评估
这个 Issue 还没有评估数据。