box / box/box-python-sdk

Log failed Preflight check at INFO level

オープン
#527 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
enhancement
主要言語
Python
スター
459
フォーク
223
平均マージ
8時間 57分
マージ済み PR(30日)
13

説明

### Is your feature request related to a problem? Please describe.
I don't think the preflight check, which throws a 409 when a file exists, should be logging a WARNING in the logs.

### Describe the solution you'd like
I think Preflight in particular should log with INFO level. Although I can understand the decision for Preflight to throw a 409, in this case I am calling it specifically to ask "can I overwrite this file?" So the response, whatever it is, shouldn't be a WARNING for my application.

Put another way: If the Preflight just throws a 409 and logs a warning, I don't see how that is different to simply calling folder.upload() and letting it throw the exception. Aren't I just wasting an API call?

### Describe alternatives you've considered
I really don't want to set the SDK log level to ERROR and above, but that is the only option I think?

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Start by locating the Preflight implementation and the warning log in the Python SDK. Review any existing tests for failed Preflight checks, then verify that a 409 response is still returned while the corresponding log entry uses INFO rather than WARNING.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
python
領域
api
issue の種類
機能追加
難易度
3/5
見積もり時間
1〜2日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
42/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。