box / box/box-python-sdk

Log failed Preflight check at INFO level

Open
#527 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
459
Forks
223
Avg merge
8h 57m
Merged PRs (30d)
13

Description

### Is your feature request related to a problem? Please describe.
I don't think the preflight check, which throws a 409 when a file exists, should be logging a WARNING in the logs.

### Describe the solution you'd like
I think Preflight in particular should log with INFO level. Although I can understand the decision for Preflight to throw a 409, in this case I am calling it specifically to ask "can I overwrite this file?" So the response, whatever it is, shouldn't be a WARNING for my application.

Put another way: If the Preflight just throws a 409 and logs a warning, I don't see how that is different to simply calling folder.upload() and letting it throw the exception. Aren't I just wasting an API call?

### Describe alternatives you've considered
I really don't want to set the SDK log level to ERROR and above, but that is the only option I think?

Contributor guide

Open the contributing guide

Research direction

Start by locating the Preflight implementation and the warning log in the Python SDK. Review any existing tests for failed Preflight checks, then verify that a 409 response is still returned while the corresponding log entry uses INFO rather than WARNING.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.