box / box/box-python-sdk

Log failed Preflight check at INFO level

Ouverte
#527 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
enhancement
Langage dominant
Python
Étoiles
459
Forks
223
Merge moyen
8 h 57 min
PR mergées (30 j)
13

Description

### Is your feature request related to a problem? Please describe.
I don't think the preflight check, which throws a 409 when a file exists, should be logging a WARNING in the logs.

### Describe the solution you'd like
I think Preflight in particular should log with INFO level. Although I can understand the decision for Preflight to throw a 409, in this case I am calling it specifically to ask "can I overwrite this file?" So the response, whatever it is, shouldn't be a WARNING for my application.

Put another way: If the Preflight just throws a 409 and logs a warning, I don't see how that is different to simply calling folder.upload() and letting it throw the exception. Aren't I just wasting an API call?

### Describe alternatives you've considered
I really don't want to set the SDK log level to ERROR and above, but that is the only option I think?

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.