bazel-contrib / bazel-contrib/rules_python

refactor: consolidate `_bazel.bzl` and remove semantics.bzl

Aperta
#2,522 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Can Close?
Lingua principale
Starlark
Stelle
688
Fork
721
Merge medio
15h 7m
PR unite (30g)
76

Descrizione

This issue is to track work related to consolidating and cleaning up the code now that it's been moved out of Bazel itself. The main reason for this is to simplify the implementation. When the code was in Bazel itself, having separate files for Bazel and Google-internal pieces sense because carrying patches for the code was particularly hard. However, this ended up making the code somewhat complicated: (1) a "semantics" plugin object with quite a few "hooks" into various low-level steps and (2) the "hook points" have turned into a brittle API that make it hard to communicate state from one step to another.

Most low-hanging fruit has been cleaned up, the three main things remaining are:

1. [x] Merging `py_executable_bazel.bzl` into `py_executable.bzl`
2. [x] Merging `common_bazel.bzl` into `common.bzl`
3. [x] Removing `semantics.bzl`
4. [ ] Removing "binary semantics" and "library semantics"

Cleaning this up will probably expose some natural points of simplification in how things are implemented.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Review the checklist and the remaining binary-semantics and library-semantics work in the issue. Then inspect the referenced `_bazel.bzl`, `semantics.bzl`, `py_executable.bzl`, and `common.bzl` files to understand what remains after the completed merges. Done means removing those semantics layers and simplifying the affected implementation without leaving the tracked cleanup incomplete.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Ambito
build-system
Tipo di issue
Refactoring
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.