bazel-contrib / bazel-contrib/rules_python

refactor: consolidate `_bazel.bzl` and remove semantics.bzl

Open
#2,522 0 comments 0 reactions 0 assignees View on GitHub
Can Close?
Dominant language
Starlark
Stars
688
Forks
721
Avg merge
15h 7m
Merged PRs (30d)
76

Description

This issue is to track work related to consolidating and cleaning up the code now that it's been moved out of Bazel itself. The main reason for this is to simplify the implementation. When the code was in Bazel itself, having separate files for Bazel and Google-internal pieces sense because carrying patches for the code was particularly hard. However, this ended up making the code somewhat complicated: (1) a "semantics" plugin object with quite a few "hooks" into various low-level steps and (2) the "hook points" have turned into a brittle API that make it hard to communicate state from one step to another.

Most low-hanging fruit has been cleaned up, the three main things remaining are:

1. [x] Merging `py_executable_bazel.bzl` into `py_executable.bzl`
2. [x] Merging `common_bazel.bzl` into `common.bzl`
3. [x] Removing `semantics.bzl`
4. [ ] Removing "binary semantics" and "library semantics"

Cleaning this up will probably expose some natural points of simplification in how things are implemented.

Contributor guide

Open the contributing guide

Research direction

Review the checklist and the remaining binary-semantics and library-semantics work in the issue. Then inspect the referenced `_bazel.bzl`, `semantics.bzl`, `py_executable.bzl`, and `common.bzl` files to understand what remains after the completed merges. Done means removing those semantics layers and simplifying the affected implementation without leaving the tracked cleanup incomplete.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.