bazel-contrib / bazel-contrib/rules_python
refactor: consolidate `_bazel.bzl` and remove semantics.bzl
- Langage dominant
- Starlark
- Étoiles
- 688
- Forks
- 721
- Merge moyen
- 15 h 7 min
- PR mergées (30 j)
- 76
Description
This issue is to track work related to consolidating and cleaning up the code now that it's been moved out of Bazel itself. The main reason for this is to simplify the implementation. When the code was in Bazel itself, having separate files for Bazel and Google-internal pieces sense because carrying patches for the code was particularly hard. However, this ended up making the code somewhat complicated: (1) a "semantics" plugin object with quite a few "hooks" into various low-level steps and (2) the "hook points" have turned into a brittle API that make it hard to communicate state from one step to another.
Most low-hanging fruit has been cleaned up, the three main things remaining are:
1. [x] Merging `py_executable_bazel.bzl` into `py_executable.bzl`
2. [x] Merging `common_bazel.bzl` into `common.bzl`
3. [x] Removing `semantics.bzl`
4. [ ] Removing "binary semantics" and "library semantics"
Cleaning this up will probably expose some natural points of simplification in how things are implemented.
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Examinez la checklist ainsi que le travail restant sur la sémantique binaire et la sémantique des bibliothèques dans l’issue. Inspectez ensuite les fichiers `_bazel.bzl`, `semantics.bzl`, `py_executable.bzl` et `common.bzl` référencés afin de comprendre ce qu’il reste après les merges terminés. La tâche est considérée comme terminée lorsque ces couches de sémantique sont supprimées et que l’implémentation concernée est simplifiée, sans laisser le nettoyage suivi incomplet.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Domaine
- build-system
- Type d'issue
- Refactorisation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100