bazel-contrib / bazel-contrib/rules_python

refactor: consolidate `_bazel.bzl` and remove semantics.bzl

Abierto
#2,522 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Can Close?
Lenguaje dominante
Starlark
Estrellas
688
Forks
721
Merge medio
15 h 7 min
PR fusionados (30 d)
76

Descripción

This issue is to track work related to consolidating and cleaning up the code now that it's been moved out of Bazel itself. The main reason for this is to simplify the implementation. When the code was in Bazel itself, having separate files for Bazel and Google-internal pieces sense because carrying patches for the code was particularly hard. However, this ended up making the code somewhat complicated: (1) a "semantics" plugin object with quite a few "hooks" into various low-level steps and (2) the "hook points" have turned into a brittle API that make it hard to communicate state from one step to another.

Most low-hanging fruit has been cleaned up, the three main things remaining are:

1. [x] Merging `py_executable_bazel.bzl` into `py_executable.bzl`
2. [x] Merging `common_bazel.bzl` into `common.bzl`
3. [x] Removing `semantics.bzl`
4. [ ] Removing "binary semantics" and "library semantics"

Cleaning this up will probably expose some natural points of simplification in how things are implemented.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Revisa la lista de comprobación y el trabajo restante de semántica binaria y semántica de biblioteca en el issue. Después, inspecciona los archivos `_bazel.bzl`, `semantics.bzl`, `py_executable.bzl` y `common.bzl` referenciados para entender qué queda después de los merges completados. Se considera terminado cuando se eliminen esas capas de semántica y se simplifique la implementación afectada sin dejar incompleta la limpieza registrada.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Área
build-system
Tipo de issue
Refactorización
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.