art049 / art049/my-python-event-loop
Code Restructure
- 主要言語
- Python
- スター
- 15
- フォーク
- 1
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
Enjoyed reading your code. It was quite comprehensive for your EuroPython 2024 talk. However, there were a few ideas that might make it more concise. This is a worthwhile project that you should pick back up. These are a few, but not all, of my quick observations. Implementing these may allow plugins for SELinux and osquery. Since coreutils is your home, these modifications could enable PyO3 stub files for an overlay over coreutils.
1. Binary search of cron schedules isnt very scalable.
- I'd use a heap or BST for these times. That way you can have horizontally distributed cron reads
- If you were to use your FastAPI lambda endpoint as a front-end for a SIEM, which isnt a bad idea, you would want to load balance this
- Might even be worth decoupling the call_at fxn
2. Passable locks associated with your handle data structure: parking-lot based queues
- Sometimes theres multiple handlers: for instance, high end TDM systems
- If you were to pass the per-thread loop context to PyO3/Rust, you may need to consider handling CFFI concurrency interrupts
3. Due to 2, _run_once should be rewritten to preempt... OnceLock and RwLocks would be seen here
- If you have a high end TDM system, you could have different loop contexts lock expensive resources and/or operations
4. Some of your code is redundant... abstract yourself of simple getters/setters
- Create a metaclass to help your trivial methods
5. Make the selector a TypedDict (inline dictionary in 3.14) or a dataclass
- _add_reader() and _add_writer() have been made inflexible
- Cut the implementation specific dependency so that events can be plugins
- This permits contextual EVENT_WRITEs...
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
調査の方向性
Issue では、イベントループのエントリポイントである call_at、_run_once、_add_reader()、_add_writer()、selector、および handle data が挙げられています。まず、これらのエントリポイントと現在の関係を整理してください。ファイルやテストは指定されていません。要求されている作業は 1 つの変更に限定されておらず、Issue では明確な完了基準も定義されていません。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- fastapi, python, rust
- 領域
- backend, operating-systems
- issue の種類
- リファクタリング
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 活発さ
- 停滞
- 明瞭さ
- 説明が足りない
- 初心者へのやさしさ
- 15/100