art049 / art049/my-python-event-loop
Code Restructure
- 主要语言
- Python
- 星标
- 15
- 派生
- 1
- PR 合并指标
- 30 天内没有已合并 PR
描述
Enjoyed reading your code. It was quite comprehensive for your EuroPython 2024 talk. However, there were a few ideas that might make it more concise. This is a worthwhile project that you should pick back up. These are a few, but not all, of my quick observations. Implementing these may allow plugins for SELinux and osquery. Since coreutils is your home, these modifications could enable PyO3 stub files for an overlay over coreutils.
1. Binary search of cron schedules isnt very scalable.
- I'd use a heap or BST for these times. That way you can have horizontally distributed cron reads
- If you were to use your FastAPI lambda endpoint as a front-end for a SIEM, which isnt a bad idea, you would want to load balance this
- Might even be worth decoupling the call_at fxn
2. Passable locks associated with your handle data structure: parking-lot based queues
- Sometimes theres multiple handlers: for instance, high end TDM systems
- If you were to pass the per-thread loop context to PyO3/Rust, you may need to consider handling CFFI concurrency interrupts
3. Due to 2, _run_once should be rewritten to preempt... OnceLock and RwLocks would be seen here
- If you have a high end TDM system, you could have different loop contexts lock expensive resources and/or operations
4. Some of your code is redundant... abstract yourself of simple getters/setters
- Create a metaclass to help your trivial methods
5. Make the selector a TypedDict (inline dictionary in 3.14) or a dataclass
- _add_reader() and _add_writer() have been made inflexible
- Cut the implementation specific dependency so that events can be plugins
- This permits contextual EVENT_WRITEs...
贡献指南
这个仓库没有索引到贡献指南
调研方向
Issue 列出了事件循环入口点 call_at、_run_once、_add_reader()、_add_writer()、selector 以及 handle 数据。首先梳理这些入口点及其当前关系;其中没有指定文件或测试。所请求的工作不局限于一次更改,并且 issue 没有定义明确的完成标准。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- fastapi, python, rust
- 领域
- backend, operating-systems
- Issue 类型
- 重构
- 难度
- 5/5
- 预计耗时
- 一周以上
- 活跃度
- 停滞
- 描述清晰度
- 需要澄清
- 新手友好度
- 15/100