appsmithorg / appsmithorg/appsmith

Better abstractions in widget operations

Open
#3,393 1 comment 0 reactions 1 assignee Claimed by @riodeuno View on GitHub
Task UI Building Product
Dominant language
TypeScript
Stars
40.9k
Forks
4.8k
Avg merge
1d 22h
Merged PRs (30d)
45

Description

Can we ensure that we don't leak abstractions here? Technically, the WidgetOperationSaga should be agnostic to the widget being deleted. Since the tab widget has special handling, we should have a function called `deleteWidget` in the `BaseWidget` class with an empty implementation. If any widget requires a special handling, the specific widget should override it's implementation of the `delete` function to fire the specific event.

_Originally posted by @mohanarpit in https://github.com/appsmithorg/appsmith/pull/3218#discussion_r582884240_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.