apex-dev-tools / apex-dev-tools/apex-ls

NPM release is not set up right

Aperta
#335 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
code quality
Lingua principale
Scala
Stelle
12
Fork
3
Merge medio
13h 43m
PR unite (30g)
19

Descrizione

Noticed that none of the npm dependencies are actually used since CodeParser, xml, vf types etc. are not "exported top level" from scala js. But doing this interferes with consumers of the sjs jar (it causes it to be exported from their npm releases).

Because of the conflict, the apex-ls npm release should probably be a separate sbt project (or adjacent dir) that depends on apex-ls sjs. Only exported types (like Workspaces) should be included. Then extras like the parsers, xmldom etc. if they are needed would have to be extended to provide an exportable name in the npm release. Assuming you can't just re-export stuff in scala js.

Doing this prevents the exports from polluting downstream, and makes it easier for them to switch to ESM builds.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.