apex-dev-tools / apex-dev-tools/apex-ls

NPM release is not set up right

Offen
#335 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
code quality
Vorherrschende Sprache
Scala
Sterne
12
Forks
3
Ø Merge
13 Std. 43 Min.
Gemergte PRs (30 T.)
19

Beschreibung

Noticed that none of the npm dependencies are actually used since CodeParser, xml, vf types etc. are not "exported top level" from scala js. But doing this interferes with consumers of the sjs jar (it causes it to be exported from their npm releases).

Because of the conflict, the apex-ls npm release should probably be a separate sbt project (or adjacent dir) that depends on apex-ls sjs. Only exported types (like Workspaces) should be included. Then extras like the parsers, xmldom etc. if they are needed would have to be extended to provide an exportable name in the npm release. Assuming you can't just re-export stuff in scala js.

Doing this prevents the exports from polluting downstream, and makes it easier for them to switch to ESM builds.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.