apex-dev-tools / apex-dev-tools/apex-ls

NPM release is not set up right

Open
#335 0 comments 0 reactions 0 assignees View on GitHub
code quality
Dominant language
Scala
Stars
12
Forks
3
Avg merge
13h 43m
Merged PRs (30d)
19

Description

Noticed that none of the npm dependencies are actually used since CodeParser, xml, vf types etc. are not "exported top level" from scala js. But doing this interferes with consumers of the sjs jar (it causes it to be exported from their npm releases).

Because of the conflict, the apex-ls npm release should probably be a separate sbt project (or adjacent dir) that depends on apex-ls sjs. Only exported types (like Workspaces) should be included. Then extras like the parsers, xmldom etc. if they are needed would have to be extended to provide an exportable name in the npm release. Assuming you can't just re-export stuff in scala js.

Doing this prevents the exports from polluting downstream, and makes it easier for them to switch to ESM builds.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.