apex-dev-tools / apex-dev-tools/apex-ls

NPM release is not set up right

Abierto
#335 0 comentarios 0 reacciones 0 asignados Ver en GitHub
code quality
Lenguaje dominante
Scala
Estrellas
12
Forks
3
Merge medio
13 h 43 min
PR fusionados (30 d)
19

Descripción

Noticed that none of the npm dependencies are actually used since CodeParser, xml, vf types etc. are not "exported top level" from scala js. But doing this interferes with consumers of the sjs jar (it causes it to be exported from their npm releases).

Because of the conflict, the apex-ls npm release should probably be a separate sbt project (or adjacent dir) that depends on apex-ls sjs. Only exported types (like Workspaces) should be included. Then extras like the parsers, xmldom etc. if they are needed would have to be extended to provide an exportable name in the npm release. Assuming you can't just re-export stuff in scala js.

Doing this prevents the exports from polluting downstream, and makes it easier for them to switch to ESM builds.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.