apex-dev-tools / apex-dev-tools/apex-ls

NPM release is not set up right

Aberta
#335 0 comentários 0 reações 0 responsáveis Ver no GitHub
code quality
Linguagem predominante
Scala
Estrelas
12
Forks
3
Merge médio
13h 43min
PRs com merge (30d)
19

Descrição

Noticed that none of the npm dependencies are actually used since CodeParser, xml, vf types etc. are not "exported top level" from scala js. But doing this interferes with consumers of the sjs jar (it causes it to be exported from their npm releases).

Because of the conflict, the apex-ls npm release should probably be a separate sbt project (or adjacent dir) that depends on apex-ls sjs. Only exported types (like Workspaces) should be included. Then extras like the parsers, xmldom etc. if they are needed would have to be extended to provide an exportable name in the npm release. Assuming you can't just re-export stuff in scala js.

Doing this prevents the exports from polluting downstream, and makes it easier for them to switch to ESM builds.

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.